boolean <-> std_logic conversion functions#4
Open
ralight wants to merge 1 commit intomartinjthompson:masterfrom
ralight:master
Open
boolean <-> std_logic conversion functions#4ralight wants to merge 1 commit intomartinjthompson:masterfrom ralight:master
ralight wants to merge 1 commit intomartinjthompson:masterfrom
ralight:master
Conversation
Owner
|
Thanks for those - before I merge them, could you please add some testcases at the bottom (I know they're trivial, but it does flag up the fact that a ieee.std_logic_1164 clause hasn't been added in your pull request :) Also, I assume you are happy for me to add you the list of "authors waiving copyright" in the header? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find these functions very useful. Let's hope other people provide you with lots of other examples!