Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Martin,
I changed the way import gevent to avoid monkey patching.
Although tests pass I have an exception running them in the error greenlet :
Traceback (most recent call last):
File "/Users/gwik/Development/gauss/people_service/lib/python2.7/site-packages/gevent-1.0a3-py2.7-macosx-10.7-x86_64.egg/gevent/greenlet.py", line 402, in run
result = self._run(_self.args, *_self.kwargs)
File "/Users/gwik/Development/gauss/people_service/src/applepushnotification/applepushnotification/service.py", line 139, in _error_loop
self._push_connection.close()
AttributeError: 'NoneType' object has no attribute 'close'
<Greenlet at 0x101483958: <bound method NotificationService._error_loop of <applepushnotification.service.NotificationService object at 0x101486050>>> failed with AttributeError
Is it a known side effect ?
Thank you for this lib.
Antonin