🔄 Package: Move update-notifier removal into the packaging playbook#257
Merged
🔄 Package: Move update-notifier removal into the packaging playbook#257
update-notifier removal into the packaging playbook#257Conversation
mbercx
force-pushed
the
ref/update-notifier
branch
2 times, most recently
from
3f81117 to
84fd628
Compare
Removing the `update-notifier` package during GUI customisation had the side-effect of invalidating apt state in a way that could surface later in the same provisioning run — the `ensure-apt-pip` refresh honoured `cache_valid_time: 86400` and skipped re-updating, so subsequent tasks occasionally failed to find standard packages like `ubuntu-desktop-minimal`, which would break provisioning even if they had already been installed. Move the purge out of `local/tasks/customise-gui.yml` and into `playbook-package.yml`, where it now runs right after the VM reload and before the disk cleanup. This keeps the Software Updater popup off the shipped image (the only place it actually matters — dev VMs re-provisioned locally can still show it, which is not an issue) without touching apt state mid-build.
Collaborator
Author
|
CI failing again because of PseudoDojo 🙄 Strangely enough: transient issue seems more prevalent for AMD64? May be a coincidence. |
mbercx
force-pushed
the
ref/update-notifier
branch
from
84fd628 to
24e7c11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the
update-notifierpackage during GUI customisation had the side-effect of invalidating apt state in a way that could surface later in the same provisioning run — theensure-apt-piprefresh honouredcache_valid_time: 86400and skipped re-updating, so subsequent tasks occasionally failed to find standard packages likeubuntu-desktop-minimal, which would break provisioning even if they had already been installed.Move the purge out of
local/tasks/customise-gui.ymland intoplaybook-package.yml, where it now runs right after the VM reload and before the disk cleanup. This keeps the Software Updater popup off the shipped image (the only place it actually matters — dev VMs re-provisioned locally can still show it, which is not an issue) without touching apt state mid-build.