Fix additional trailing zeros being counted as version upgrade #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reformat code. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
|
Member
|
@WarningImHack3r Thanks. I updated your code, then merged it. Will release 5.0.2. |
|
Thanks @WarningImHack3r @rgoldberg, this fixed a very similar issue for me! App Store reported version 1.3.2. (with a trailing dot) and downloaded version was 1.3.2 (no dot) |
Member
|
@jabenninghoff Ignoring an empty element should actually be from #1155 from mas 4.1.2. but this PR is obviously useful for trailing zero elements. |
|
Ah, I hadn't checked in a while, thanks just the same! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I met the following case:
This PR fixes this by omitting the trailing zeros during version comparison if all the other digits are equal.
Resolve #1176
Note
The
dropLastimplementation comes from here: https://stackoverflow.com/a/62306093/12070367