Conversation
tarasovxx
reviewed
Jul 4, 2024
Collaborator
tarasovxx
left a comment
tarasovxx
left a comment
There was a problem hiding this comment.
Код в целом хороший, но есть некоторые моменты, которые можно улучшить для повышения стабильности и читаемости.
|
|
||
| void Allocator::makeAllocator(size_t max_size) { | ||
| if (max_size == 0) | ||
| return; |
Collaborator
There was a problem hiding this comment.
Добавить вывод (логирование), чтобы пользователь понимал, что не так
| try { | ||
| ptr_ = new char[max_size]; | ||
| } catch (...) { | ||
| throw; |
Collaborator
There was a problem hiding this comment.
Это избыточно. Если не собираешься обрабатывать исключение, лучше вообще не использовать try-catch. Так как это тяжелая конструкция.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created the header and source file for the Allocator
Made the source file for the test
Edited the Makefile for the possibility of a test