Conversation
added 14 commits
June 23, 2024 17:57
tarasovxx
reviewed
Jul 15, 2024
Collaborator
tarasovxx
left a comment
tarasovxx
left a comment
There was a problem hiding this comment.
В целом работа выполнена неплохо, есть маленькие замечания по исправлению, ознакомься!
| #include <string> | ||
|
|
||
| // Custom exceptions | ||
| class StreamOutputException : public std::exception { |
Collaborator
There was a problem hiding this comment.
Классы исключений StreamOutputException, WrongStringFormat и InvalidArguments можно сделать наследниками от std::runtime_error, чтобы иметь возможность передавать сообщение об ошибке в конструктор базового класса. Тогда не потребуется отдельное поле msg_ и метод what().
|
|
||
| // Recursion step | ||
| template <typename Cur, typename... Args> | ||
| std::string formatHelper(const std::string& string_format, |
Collaborator
There was a problem hiding this comment.
std::string_view вместо const std::string& для параметра string_format
| // Go through string char by char | ||
| for (size_t i = 0; i != string_format.length(); ++i) { | ||
| // WARN: Meet closing bracket before opening one | ||
| if (string_format[i] == '}') { |
Collaborator
There was a problem hiding this comment.
std::string::find вместо ручного поиска символов { и }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.