Conversation
tarasovxx
reviewed
Jul 16, 2024
Collaborator
tarasovxx
left a comment
tarasovxx
left a comment
There was a problem hiding this comment.
Ты абсолютно верно подметил замечания. Также могу посоветовать использовать умный указатели, чтобы не было мороки с памятью, так будет проще для тебя. В целом замечаний я больше не увидел
|
|
||
| // Internal structures | ||
| struct node { | ||
| const key_type first; |
Collaborator
There was a problem hiding this comment.
Можно унести в private, чтобы не нарушать инкапсуляцию
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Артём, приношу извинения за позднюю отправку, надеюсь, меня ещё можно пощадить из-за болезни
В целом, работа далеко не идеальная
Что плохо:
std::map- особенно для работы с итераторами.cpp, но уже начал работать такЧто прикольно:
std::mapи наполовину это получилось