Skip to content

DP-46272: Fix missing tag number in environment indicator#3334

Merged
arthurbaghdas merged 7 commits intodevelopfrom
feature/DP-46272-environment-indicator-tag-number
Apr 15, 2026
Merged

DP-46272: Fix missing tag number in environment indicator#3334
arthurbaghdas merged 7 commits intodevelopfrom
feature/DP-46272-environment-indicator-tag-number

Conversation

@dstorozhuk
Copy link
Copy Markdown
Collaborator

Description:
Explain the technical implementation of the work done.

Jira: (Skip unless you are MA staff)
DP-****

To Test:

  • Add steps to test this feature

Peer Review Checklist

Swap version_identifier priority so deployment_identifier (set by
stamp-and-deploy during CI) is the primary source instead of
environment_indicator_current_release (Drupal state key that is
never set during Acquia deploys).

The 4.0.25 upgrade introduced a bug where getVersionIdentifier()
casts NULL state values to empty string "", preventing the
null-coalescing fallback from reaching deployment_identifier.
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 17:59 Destroyed
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 18:07 Destroyed
Restoring original priority (environment_indicator_current_release as
primary, deployment_identifier as fallback) to verify Tugboat preview
shows the tag number correctly before changing production config.
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 18:39 Destroyed
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 19:44 Destroyed
- Swap version_identifier config so deployment_identifier is primary
  (used by Acquia via stamp-and-deploy) and
  environment_indicator_current_release is fallback (used by Tugboat
  via drush sset)
- Add drush sset to Tugboat build step so tag shows on PR previews
  rebuilt from base preview (build skips init/update steps)
@dstorozhuk dstorozhuk force-pushed the feature/DP-46272-environment-indicator-tag-number branch from 315c260 to 7f00ccd Compare April 14, 2026 20:00
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 20:00 Destroyed
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 20:26 Destroyed
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 20:41 Destroyed
@dstorozhuk dstorozhuk force-pushed the feature/DP-46272-environment-indicator-tag-number branch from 2c4cab5 to 6a2471d Compare April 14, 2026 21:00
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 21:00 Destroyed
Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
@dstorozhuk dstorozhuk force-pushed the feature/DP-46272-environment-indicator-tag-number branch from 6a2471d to 1e600d9 Compare April 14, 2026 21:06
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 21:06 Destroyed
Signed-off-by: Dmytro Storozhuk <dima@itech4web.com>
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 14, 2026 21:56 Destroyed
@arthurbaghdas arthurbaghdas temporarily deployed to Tugboat April 15, 2026 09:27 Destroyed
@arthurbaghdas arthurbaghdas merged commit 5233904 into develop Apr 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants