fix(Active Mode): enable Critical Hit text for Rams#1700
Draft
msprijatelj wants to merge 1 commit intomassif-press:masterfrom
Draft
fix(Active Mode): enable Critical Hit text for Rams#1700msprijatelj wants to merge 1 commit intomassif-press:masterfrom
msprijatelj wants to merge 1 commit intomassif-press:masterfrom
Conversation
This change borrows some Critical Hit decorators from `_WeaponAttack.vue` to indicate when a Ram is a critical hit. Closes massif-press#1681
Contributor
Author
|
Converting this to draft for now. Ideally would like some feedback before this one gets merged (if at all), and I’m not feeling great about the current execution. |
Contributor
|
Would you be able to post screenshots of what this looks like both without and with a crit roll, please? |
Contributor
Author
|
Added the same "CRITICAL" text from Skirmish under a critical attack roll: Ram results with a Critical Hit: Ram results with a Normal Hit: Ram results on a failure: |
Contributor
Author
|
Compared to Skirmish Critical Hit: And Skirmish Normal Hit: |
Contributor
Author
|
Realizing that the "Hit" box color is different for a critical hit instead of a normal hit when using Skirmish; I'll have to include that behavior for Ram if I continue with this PR. |
Contributor
|
I like this change. It's niche, but I can see it's usefulness |
TranslucentSabre
approved these changes
Jan 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change borrows some Critical Hit decorators from
_WeaponAttack.vueto indicate when a Ram is a critical hit, since the Critical Hit matters in some scenarios.I'm not super familiar with Vuetify styling, otherwise the results would be a bit more appealing. If you have any advice on how to improve the styling, please let me know and I'll make the proper modifications.
Issue Number
Closes #1681
Type of change