Prevent rewriting strict inequality to closed interval for non-discrete types #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friede80
force-pushed
the
friede/fix-view-matching-inequality-filters
branch
from
0bb1df5 to
1ca87ab
Compare
wyatt-herkamp
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When normalizing filters for materialized view matching, strict inequalities (e.g.
< '2025-03-21') were being converted to closed intervals usingsatisfy_greater. For non-discrete types like strings, this resulted in the same value being used (e.g.<= '2025-03-21'), inadvertently changing the query semantics