updating all refs to massive and updating benzinga to be real time #40
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return | ||
|
|
||
| print("Testing list_benzinga_news v2 API integration") | ||
| print(f"API Key: {api_key[:10]}...{api_key[-4:] if len(api_key) > 14 else '****'}") |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 months ago
To fix the problem, remove the print statement that exposes any portion of the sensitive API key. Instead of outputting the actual value or any substring thereof, print a message indicating that the API key is set without revealing any part of it. This maintains the logic flow (still confirming that the API key is loaded), but avoids logging even a partial secret.
Details:
- Only replace line 145 and its string output.
- You may print something generic (e.g., "API Key found in environment.") or similar.
- No changes to logic, imports, or additional functions are necessary, as only the output format is altered.
- Ensure that the replacement line gives no hint of the API key’s contents or length.
| @@ -142,7 +142,7 @@ | ||
| return | ||
|
|
||
| print("Testing list_benzinga_news v2 API integration") | ||
| print(f"API Key: {api_key[:10]}...{api_key[-4:] if len(api_key) > 14 else '****'}") | ||
| print("API Key: [REDACTED] (loaded from environment)") | ||
| print() | ||
|
|
||
| tests = [ |
There was a problem hiding this comment.
Clear-text logging of sensitive information
This expression logs sensitive data (password) as clear text.
pyproject.toml
Outdated
| "mcp[cli]>=1.15.0", | ||
| "polygon-api-client>=1.15.4", | ||
| "massive>=2.0.1", | ||
| "python-dotenv>=1.0.0", |
There was a problem hiding this comment.
Looks like the latest version of python-dotenv is 1.2.1. Can we set this to "python-dotenv>=1.2.0" to stay close to current?
joedursun
left a comment
joedursun
left a comment
There was a problem hiding this comment.
Just one minor comment but overall LGTM. Thanks, @Smartoneinok!
|
@nsknithish13-cmd |
ghost
mentioned this pull request
|
@nsknithish13-cmd |
ghost
mentioned this pull request
|
ghost
mentioned this pull request
I updated the polygon client to be the massive client and updated it to the most recent version.
I also changed the list_benzinga_news to use the new v2 method in the client. I tested this with the inspector. Added in a test class for this as well as .env testing capability.