Skip to content

Implement array compaction for oversized queue #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abolix wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement array compaction for oversized queue #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions internal/mlq/mlq.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ func (m *MultiLevelQueue[T]) popLocked(keyExtractor func(T) uint32) (T, int, boo
q.Items[0] = zero
q.Items = q.Items[1:]

// Compact the backing array when it becomes significantly oversized
// to prevent unbounded memory growth from repeated push/pop cycles.
if cap(q.Items) > 64 && len(q.Items) < cap(q.Items)/4 {
compact := make([]T, len(q.Items))
copy(compact, q.Items)
q.Items = compact
}

// Update census and bitmask
if keyExtractor != nil {
delete(m.census, keyExtractor(item))
Expand Down Expand Up @@ -193,6 +201,13 @@ func (m *MultiLevelQueue[T]) PopIf(priority int, predicate func(T) bool, keyExtr
q.Items[0] = zero // Memory safety
q.Items = q.Items[1:]

// Compact the backing array when it becomes significantly oversized
if cap(q.Items) > 64 && len(q.Items) < cap(q.Items)/4 {
compact := make([]T, len(q.Items))
copy(compact, q.Items)
q.Items = compact
}

if keyExtractor != nil {
delete(m.census, keyExtractor(item))
}
Expand Down
Loading