Skip to content

feat(currency-convert): support zero decimal option#2117

Draft
Najibmansour wants to merge 1 commit intomastermunj:mainfrom
Najibmansour:Allow_fractionalUnit_when_zero_#1867
Draft

feat(currency-convert): support zero decimal option#2117
Najibmansour wants to merge 1 commit intomastermunj:mainfrom
Najibmansour:Allow_fractionalUnit_when_zero_#1867

Conversation

@Najibmansour
Copy link

Feature: Support zero-decimal option

Summary

This pull request introduces initial support for a zero-decimal option in the pricing/amount logic.
The core implementation is complete, but testing and documentation are not yet finalized.
This PR is intentionally opened early to share the approach and gather feedback before completion.

What’s implemented

  • Core logic to handle zero-decimal values

What’s not done yet

  • Unit tests
  • Integration and edge-case tests
  • Documentation updates

Testing

  • Tested failing on 3 locales working on issue
    (Tests will be added before merging)

###Documentation
Documentation will be updated once the behavior is validated and finalized

Work in Progress
Feedback is welcome before proceeding with tests and documentation.

@mastermunj
Copy link
Owner

Hi @Najibmansour , can you help share a few examples about the behaviour change? It will be clearer to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants