feat(currency-convert): support zero decimal option#2117
Draft
Najibmansour wants to merge 1 commit intomastermunj:mainfrom
Draft
feat(currency-convert): support zero decimal option#2117Najibmansour wants to merge 1 commit intomastermunj:mainfrom
Najibmansour wants to merge 1 commit intomastermunj:mainfrom
Conversation
Owner
|
Hi @Najibmansour , can you help share a few examples about the behaviour change? It will be clearer to understand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Support zero-decimal option
Summary
This pull request introduces initial support for a zero-decimal option in the pricing/amount logic.
The core implementation is complete, but testing and documentation are not yet finalized.
This PR is intentionally opened early to share the approach and gather feedback before completion.
What’s implemented
What’s not done yet
Testing
(Tests will be added before merging)
###Documentation
Documentation will be updated once the behavior is validated and finalized
Work in Progress
Feedback is welcome before proceeding with tests and documentation.