Security #3
Open
Security #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterzen
reviewed
Apr 28, 2022
Owner
masterzen
left a comment
masterzen
left a comment
There was a problem hiding this comment.
This looks good, but:
- check the
refreshvsrefrestypo - please rebase on top of master, since I've merged the other PR
Thanks!
redis-snmp
Outdated
| oid => '1.3.6.1.4.1.20267.400.1', | ||
| port => 6379, | ||
| refresh => 300, | ||
| refres => 300, |
Owner
There was a problem hiding this comment.
This change looks suspicious :)
Contributor
Author
|
I did the following changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
the recent version reads the client password from the command line options. Hence the password is visible in the process table. You can see it for example with "ps -ef". This is a security risk.
I tried to fix this: Therefore I added a configuration parameter "-c" that requires the redis server configuration path. Now, redis-snmp tries to read the client password from the redis server configuration. To make life a little bit easier a default redis server configuration path "/etc/redis/redis.conf" is used. This means for the default case that this is the path of the user's redis server configuration the user needs neither parameter "-c" nor parameter "-p".