Conversation
Deploying apg-patterns-examples with
|
| Latest commit: |
2196b43
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da5c7105.apg-patterns-examples.pages.dev |
| Branch Preview URL: | https://chore-astro6-upgrade.apg-patterns-examples.pages.dev |
- Upgrade astro to v6.0.4 with all official integrations (@astrojs/mdx v5, @astrojs/react v5, @astrojs/svelte v8, @astrojs/vue v6) - Migrate vite.build.rollupOptions to vite.environments.client.build for Vite 7 - Migrate z import from astro:content to astro/zod (Astro 6 requirement) - Migrate Astro.site to import.meta.env.SITE in BaseLayout - Update CI Node.js version from 20 to 22 across all 7 jobs - Update engines.node to >=22.12.0 - Update Vitest 4.0.16 to 4.1.0 for Vite 7 CJS interop fix - Add resolve.alias workaround for lucide-svelte ESM compatibility with Vite 7's Tailwind ESM cache loader Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The previous lock file was generated with --legacy-peer-deps which caused missing entries (vue-eslint-parser, eslint-visitor-keys), failing npm ci in CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix Prettier formatting in astro.config.mjs - Add .node-version (22) so Cloudflare Pages uses Node 22 instead of the default Node 20, which is required by Astro 6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Align with local development environment (v24.12.0). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
masuP9
force-pushed
the
chore/astro6-upgrade
branch
from
40541fa to
2196b43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollupOptions→environments.client.build, ESM compatibility fixes)zimport toastro/zodandAstro.sitetoimport.meta.env.SITEBreaking Changes Addressed
vite.build.rollupOptions→vite.environments.client.build.rollupOptions(Vite 7)import { z } from 'astro:content'→import { z } from 'astro/zod'(Astro 6)Astro.site→import.meta.env.SITE(Astro 6 deprecation)Additional Fixes (not in original plan)
resolve.aliasto fix extensionless internal imports that fail with Tailwind's ESM cache loader in Vite 7 (marked asWORKAROUNDwithTODOfor upstream fix)cookiepackageexports is not definederror)Test plan
npm run buildpasses with no errorsnpm run lint:astro— 0 errors, 0 warningsnpm run lint:types— passesnpm run test:react— 29 files, 1257 tests passednpm run test:vue— 23 files, 700 tests passednpm run test:svelte— 23 files, 667 tests passednpm run test:astro— 6 files, 144 tests passedgetStaticPathsparams verified as string type in all 8 files🤖 Generated with Claude Code