Skip to content

Create test2.txt#3

Open
mzinger wants to merge 4 commits intomatan-test-1:masterfrom
mzinger:patch-1
Open

Create test2.txt#3
mzinger wants to merge 4 commits intomatan-test-1:masterfrom
mzinger:patch-1

Conversation

@mzinger
Copy link
Copy Markdown

@mzinger mzinger commented Jul 26, 2019

This change is Reviewable

Copy link
Copy Markdown
Owner

@matan-test-1 matan-test-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some work needed

@@ -0,0 +1,5 @@
Another test file.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for empty line

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the empty line though

Copy link
Copy Markdown
Owner

@matan-test-1 matan-test-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there...

Copy link
Copy Markdown
Owner

@matan-test-1 matan-test-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there...

Co-Authored-By: matan-test-1 <53353345+matan-test-1@users.noreply.github.com>
Copy link
Copy Markdown
Owner

@matan-test-1 matan-test-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 5 unresolved discussions (waiting on @mzinger)


test2.txt, line 2 at r2 (raw file):

Previously, mzinger wrote…

I like the empty line though

Please remove as per guidelines, or add a comment justifying it.


test2.txt, line 4 at r4 (raw file):


This file is used as a sandbox for doing a thorough review.

Minor: another empty line

Copy link
Copy Markdown
Author

@mzinger mzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @matan-test-1)


test2.txt, line 1 at r1 (raw file):

Previously, matan-test-1 wrote…

Add some more content

Done.


test2.txt, line 2 at r2 (raw file):

Previously, matan-test-1 wrote…

Please remove as per guidelines, or add a comment justifying it.

Done.


test2.txt, line 3 at r2 (raw file):

Previously, matan-test-1 wrote…

s/conducting/doing

Done.


test2.txt, line 5 at r2 (raw file):

Previously, matan-test-1 wrote…
I can also say at this point that the jury is still out on pull request code reviews.

Done.

Copy link
Copy Markdown
Owner

@matan-test-1 matan-test-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @matan-test-1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants