This repository was archived by the owner on Mar 27, 2023. It is now read-only.
Prevent required properties in conditionals #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrne
reviewed
Aug 22, 2020
Member
bjrne
left a comment
bjrne
left a comment
There was a problem hiding this comment.
Untested, but code seems fine. Will test.
Collaborator
Author
|
@maltezacharias turns out the signup bug was already fixed here ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not invest time to handle required properties in conditionals, which can make problems on signup. For now, we thus throw an error if someone sets up a configuration with this property.