Skip to content

Fix load validation#285

Merged
niekdejonge merged 4 commits intomainfrom
fix_load_validation
Feb 5, 2026
Merged

Fix load validation#285
niekdejonge merged 4 commits intomainfrom
fix_load_validation

Conversation

@niekdejonge
Copy link
Collaborator

@niekdejonge niekdejonge commented Feb 2, 2026

Fixes bug when loading files.
The bug was caused since a new validation step was added in SettingsMS2DeepScore outside of validate settings. Therefore it was not skipped if validate_settings = False, making the loading break, since the input spectrum file does not exist when running.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@niekdejonge niekdejonge merged commit b3b27ff into main Feb 5, 2026
12 checks passed
@niekdejonge niekdejonge deleted the fix_load_validation branch February 5, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant