Landing#24
Open
grynkiv0x001 wants to merge 17 commits intomate-academy:masterfrom
grynkiv0x001:develop
Open
Conversation
ArtemTopolskyi
requested changes
Jun 15, 2021
ArtemTopolskyi
left a comment
ArtemTopolskyi
left a comment
There was a problem hiding this comment.
Эти ссылки никуда не ведет
В остальном гуд, делай адаптив
src/index.html
Outdated
| </ul> | ||
| </div> | ||
| <div class="nav__contacts"> | ||
| <a href="#" class="nav__contacts-phone">+00 123 456 789</a> |
There was a problem hiding this comment.
Suggested change
| <a href="#" class="nav__contacts-phone">+00 123 456 789</a> | |
| <a hhref="tel:+00123456789" class="nav__contacts-phone">+00 123 456 789</a> |
ArtemTopolskyi
requested changes
Jun 17, 2021
ArtemTopolskyi
left a comment
ArtemTopolskyi
left a comment
There was a problem hiding this comment.
На 650px футер слипается, ведет себя странно на меньшей ширине
На 550px нет отступов от краев экрана
сделай меньше шрифт, это не окей
ArtemTopolskyi
requested changes
Jun 22, 2021
ArtemTopolskyi
left a comment
ArtemTopolskyi
left a comment
There was a problem hiding this comment.
Добавь ограничение по ширине для футера
Добавь отступы сверху, кнопки прилипли к верхнему краю экрана
Добавь отступы справа и слева для этого текста
Author
Я так понимаю ограничивать ширину надо для каждого блока, сейчас это сделаю |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://grynkiv0x001.github.io/Digits/