Skip to content

task-digits-done#29

Open
RomanMinchenko wants to merge 2 commits intomate-academy:masterfrom
RomanMinchenko:develop
Open

task-digits-done#29
RomanMinchenko wants to merge 2 commits intomate-academy:masterfrom
RomanMinchenko:develop

Conversation

@RomanMinchenko
Copy link
Copy Markdown

@RomanMinchenko RomanMinchenko commented Aug 12, 2021

Copy link
Copy Markdown

@vkryvytskyi vkryvytskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +134 to +142
<g>
<path id="SVGID_13_" class="st0" d="M237.6,641c-2.1,0-3.2,2-1.9,3.5h-0.1L250,665c4.6,6.5,9.3,13.2,13.9,19.5l-28.3,40h0.1
c-1.4,1.5-0.2,3.5,1.9,3.5h16.9c0.5,0,1.7-0.4,2.2-0.9l18.9-26.4l18.8,26.3c0.5,0.6,1.7,0.9,2.2,0.9h16.9c2.2,0,3.4-2,2-3.5h0.1
c-4.1-5.6-8.2-11.7-12.3-17.3c-5.3-7.4-10.8-15.2-16.1-22.5h-13.5v-19.1l-17-23.7c-0.5-0.6-1.6-0.9-2.2-0.9L237.6,641L237.6,641z"
/>
</g>
<g>
<defs>
<path id="SVGID_20_" d="M237.6,641c-2.1,0-3.2,2-1.9,3.5h-0.1L250,665c4.6,6.5,9.3,13.2,13.9,19.5l-28.3,40h0.1
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут что-то с форматированием не то

color: #fff;

cursor: pointer;
transition: all 0.3s;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не используй transition all, указывай какое свойство анимируешь


&:hover {
color: #fff;
// border-color: #005ecc;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Удаляй комментарии

Comment on lines +6 to +7
border-top: 1px solid $textColor2;
border-bottom: 1px solid $textColor2;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что значит textColor2? Давай название более понятное secondaryTextColor

}

&__description {
@include adaptiv-font(15);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@include adaptiv-font(15);
@include adaptive-font(15);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants