Open
Conversation
Author
|
В файлі person.scss залишив робочі примітки на випадок як що прийдеться корегувати |
aliceblunt8
previously requested changes
Jan 13, 2022
aliceblunt8
left a comment
aliceblunt8
left a comment
There was a problem hiding this comment.
- add hover-effects for all buttons on the page
- add anchor links, so clicking on menu item will lead to the related section
- add links to social media to each link, add hover effect, open in new tab
- add
scroll-behavior: smooth;to HTML
https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior - mobile menu looks weird, maybe make it the same as in Miami landing
- let's add more distance between these logos on mobile
- add bigger padding to header on smaller screens
Author
|
I added scroll-behavior: smooth but haven't result. What I did wrong? How this network is called? |
vkryvytskyi
approved these changes
Jan 20, 2022
| margin: 0; | ||
| background: $c-white; | ||
|
|
||
| scroll-behavior: smooth; |
There was a problem hiding this comment.
Это правило надо добавлять на html, а не на body, чтобы оно работало
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.