Open
Conversation
dtsehelnyk
commented
Dec 9, 2020
dtsehelnyk
commented
- DEMO LINK
mgrinko
suggested changes
Dec 10, 2020
There was a problem hiding this comment.
Отличная работа!!!
Есть несколько замечаний
- надо не форкнуть gulp-template а нажать кнопку
use this templateи создать свой репозиторий с любым именем - переделай пожалуйста - У тебя нет проверки на то что цифры разные - добавь пожалуйста
- Не проверки что введено именно 4 цифры а не 3 и не 5
- Было бы здорово сбоку показать правила
- Игра не останавливается после победы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.