Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on implementing the sort2 method! Your solution correctly handles both the default sort behavior and the use of a custom compareFunction, meeting all the requirements for this task. I am approving your submission.
One small suggestion for even cleaner code: in src/arrayMethodSort.js, the item variable used for swapping could be declared inside the if block where it's used. This would narrow its scope, which is a good practice. This is a minor point, and your overall implementation is very strong. Keep it up!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| // Adiciona o método sort2 ao protótipo de Array | ||
| [].__proto__.sort2 = function (compareFunction = defaultCompare) { | ||
| const arr = this; | ||
| let item = arr[0]; |
There was a problem hiding this comment.
The item variable is initialized here with arr[0], but this initial value is never actually used. The variable is reassigned within the loop before it's used for swapping. To improve clarity and keep the variable's scope as narrow as possible, consider declaring it just before it's needed inside the loop.
3 participants
Este código adiciona ao Array um método sort2, que ordena os elementos usando uma função de comparação personalizada ou uma padrão simples, tratando valores undefined e retornando o array reorganizado.