Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the custom sort2 method! The logic for handling a custom compareFunction is well done. However, I'm requesting a change because the default sorting behavior has a critical issue. Your implementation will crash with a TypeError if the array contains null or undefined values, as you cannot call .toString() on them. The native Array.prototype.sort handles these cases without error. Please update your code to handle these special values gracefully. You could, for example, use the String() constructor, which works for null and undefined, or add explicit checks for these values.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/arrayMethodSort.js
Outdated
| hasChanged = true; | ||
| } | ||
| } else { | ||
| if (this[i - 1].toString() > this[i].toString()) { |
There was a problem hiding this comment.
This implementation for the default sort order will throw an error if an array element is null or undefined, because these values don't have a .toString() method. The native sort method handles these cases without crashing. You should adjust the logic to handle null and undefined gracefully, for example by using the String() constructor which can convert them, or by adding specific checks.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am approving your solution. You have successfully addressed the critical issue from the previous review by making the default sorting behavior robust against null and undefined values. The code is clean, and your implementation now fully meets all the requirements for the custom sort2 method. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.