Skip to content

finished project#729

Open
PadreN wants to merge 3 commits intomate-academy:masterfrom
PadreN:develop
Open

finished project#729
PadreN wants to merge 3 commits intomate-academy:masterfrom
PadreN:develop

Conversation

@PadreN
Copy link
Copy Markdown

@PadreN PadreN commented Nov 7, 2025

Copy link
Copy Markdown

@h-amster h-amster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Icon should be a part of the link, not the separate link
image image
  1. transform on navigation links in the footer is triggered far before hovering over the link
image
  1. Consider adding another hover behavior after hover on product card(add box-shadow instead of border, for example)
image
  1. Consider adding another hover behavior after hover on social links(Icon color change with transition instead of setting background-color)
image

@PadreN PadreN requested a review from h-amster November 12, 2025 07:01
Copy link
Copy Markdown

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! just add smooth scrolling to the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants