Develop by luchali · Pull Request #213 · mate-academy/node_compression-app

luchali · 2026-03-18T18:48:28Z

No description provided.

mateacademy-ai-mentor

Review Summary

Good effort in setting up the server and using the zlib module. However, this submission requires changes because it doesn't meet some of the core requirements of the task.

The most critical issue is that the file upload is not handled using streams. In src/createServer.js, the code buffers the entire request body into a string. This approach is inefficient for large files, will corrupt any binary data, and goes against the main requirement to use streams. The incoming request stream (req) should be piped through the compression stream and then to the file system.

Additionally, the file extensions for the compressed files are incorrect. The task specifies using .gz for gzip and .dfl for deflate, but the current implementation uses different extensions.

Please address these points to meet all the requirements.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-03-18T18:50:03Z

src/createServer.js

+      let body = '';
+
+      req.on('data', (chunk) => {
+        body += chunk.toString();


Buffering the entire request body into a string like this does not meet the 'use Streams' requirement for handling uploads. This approach is inefficient for large files as it consumes a lot of memory. Furthermore, chunk.toString() will corrupt any binary file data. The incoming request stream (req) should be piped through the processing steps without being fully buffered in memory.

mateacademy-ai-mentor · 2026-03-18T18:50:03Z

src/createServer.js

+
+        if (compressionType === 'gzip') {
+          compressor = zlib.createGzip();
+          ext = '.gzip';


According to the task description, the file extension for gzip compression should be .gz.

mateacademy-ai-mentor · 2026-03-18T18:50:03Z

src/createServer.js

+          ext = '.gzip';
+        } else if (compressionType === 'deflate') {
+          compressor = zlib.createDeflate();
+          ext = '.deflate';


The task description specifies the file extension for deflate compression should be .dfl.

mateacademy-ai-mentor · 2026-03-18T18:50:03Z

src/createServer.js

+          `attachment; filename=${filename}${ext}`,
+        );
+
+        const { Readable } = require('stream');


It's a best practice to place all require statements at the top of the file. This improves code readability by making dependencies clear from the start and avoids re-requiring modules unnecessarily.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Review Summary

Thanks for your submission! You've correctly set up the server routing and error handling. However, I'm requesting changes because the implementation doesn't yet meet two core requirements. The most critical issue is that the file upload process is not using streams. Your code currently buffers the entire file into a single string with body += chunk.toString(), which will fail for large files and corrupt binary data. The requirement is to pipe the incoming request stream directly into a compression stream. Additionally, the file extensions for compressed files need to be updated to match the task description: .gz for gzip and .dfl for deflate. Please focus on implementing the streaming logic for the /compress endpoint. Keep up the great work!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-03-19T20:41:40Z

src/createServer.js

+      req.on('data', (chunk) => {
+        body += chunk.toString();


The core requirement is to use streams to handle the file upload. Here, you're buffering the entire request body into a single string (body). This is inefficient, will fail for large files, and will corrupt binary files due to chunk.toString(). The incoming req object is a readable stream and should be processed as such, without collecting all the data first.

mateacademy-ai-mentor · 2026-03-19T20:41:40Z

src/createServer.js

+
+        if (compressionType === 'gzip') {
+          compressor = zlib.createGzip();
+          ext = '.gzip';


According to the task description, the file extension for gzip compression should be .gz, not .gzip.

mateacademy-ai-mentor · 2026-03-19T20:41:40Z

src/createServer.js

+          ext = '.gzip';
+        } else if (compressionType === 'deflate') {
+          compressor = zlib.createDeflate();
+          ext = '.deflate';


The task description specifies the file extension for deflate should be .dfl, not .deflate.

mateacademy-ai-mentor

Review Summary

I am approving your solution as an educational override to help you progress, but there are a couple of key areas that need your attention for future projects. You've done a great job implementing the routing and handling different error status codes correctly!

The most critical issue is that the file upload process still buffers the entire file into memory before processing it. A core requirement was to use streams to handle the upload, which is crucial for managing large files without consuming excessive memory. Instead of collecting chunks in an array with Buffer.concat(chunks), the request stream should be piped through a parser and directly into the compression stream.

Additionally, please double-check the task requirements for file extensions; gzip should produce a .gz file and deflate should produce a .dfl file. Keep up the great work, and focus on mastering streams in your next steps!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-03-21T21:11:53Z

src/createServer.js

+      req.on('data', (chunk) => {
+        chunks.push(chunk);
+      });
+
+      req.on('end', () => {
+        const buffer = Buffer.concat(chunks);


This implementation still buffers the entire request body into memory before processing it. A key requirement is to use streams to process the file upload, which means you should not collect all chunks in an array. The request stream should be processed as data arrives to avoid high memory usage and support large files. This issue was also mentioned in the previous review.

mateacademy-ai-mentor · 2026-03-21T21:11:53Z

src/createServer.js

+
+        if (compressionType === 'gzip') {
+          compressor = zlib.createGzip();
+          ext = '.gzip';


According to the task description, the file extension for gzip compression should be .gz.

mateacademy-ai-mentor · 2026-03-21T21:11:53Z

src/createServer.js

+          ext = '.gzip';
+        } else if (compressionType === 'deflate') {
+          compressor = zlib.createDeflate();
+          ext = '.deflate';


The task description specifies .dfl as the file extension for deflate compression.

AlinaLuchitska added 2 commits March 18, 2026 20:31

ver1

2f13b8b

solution

1611b42

mateacademy-ai-mentor suggested changes Mar 18, 2026

View reviewed changes

luchali requested a review from mateacademy-ai-mentor March 19, 2026 19:38

mateacademy-ai-mentor reviewed Mar 19, 2026

View reviewed changes

fix part

9276c63

luchali requested a review from mateacademy-ai-mentor March 19, 2026 19:54

mateacademy-ai-mentor suggested changes Mar 19, 2026

View reviewed changes

fix solution

6b58a72

luchali requested a review from mateacademy-ai-mentor March 21, 2026 21:10

mateacademy-ai-mentor approved these changes Mar 21, 2026

View reviewed changes

Conversation

luchali commented Mar 18, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants