Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the core file copying logic! The application correctly handles the arguments and the case where the source and destination are the same.
However, changes are needed for the error handling. The task requires you to 'Throw an error' for validation failures. Currently, you are logging messages with console.error and then returning. This causes the script to exit with a success code (0), which incorrectly signals that the operation succeeded.
Instead of logging and returning, please use throw new Error('Your error message'). This will correctly terminate the process with a non-zero exit code, indicating a failure. This change is needed for both the argument validation and the check for whether the source is a file.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| if (pathes.length !== 2) { | ||
| console.error('You need take 2 path'); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
According to the task description, you need to 'Throw an error'. Instead of logging with console.error and returning, you should use throw new Error(...). This allows for proper error handling, for instance, in a try...catch block.
| if (!states.isFile()) { | ||
| console.error('no valid path'); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
Similar to the argument check, this should also throw an error to indicate failure. The try...catch block that wraps this code will then catch it and log it correctly using console.error.
|
The task says to output errors to the console error since it's a CLI application. |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
3 participants
No description provided.