Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on setting up the server and handling the form submission! The data is being correctly saved to the expense.json file. However, a change is needed for the response after a successful submission. The requirement is to return an HTML page that displays the saved JSON data. Currently, your server in src/createServer.js sends a raw JSON response with a Content-Type of application/json. Please update the POST /add-expense handler to send back an HTML document (Content-Type: text/html) that contains the formatted JSON, for example, by placing it within <pre> tags.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/createServer.js
Outdated
| fs.writeFileSync(dataPath, JSON.stringify(expense, null, 2)); | ||
|
|
||
| // Return sucsess response with JSON | ||
| sendResponse(res, 200, 'application/json', expense); |
There was a problem hiding this comment.
The task requires returning an HTML page with well-formatted JSON. Currently, you are returning a response with Content-Type: application/json. You should instead send an HTML document (text/html) that contains the JSON, perhaps formatted within <pre> tags.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! I am happy to approve your solution. You've successfully addressed the feedback from the previous review by ensuring the POST /add-expense endpoint now returns a proper HTML page with the Content-Type set to text/html. The tests have also been updated correctly to reflect this change. All requirements are now fully met. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.