Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
You've done a great job implementing the server logic to handle the POST request and save the expense data. However, this requires changes because two key requirements are missing.
First, the server does not serve the HTML form for users to input their expenses. You'll need to add logic to handle a GET request that sends the form's HTML to the browser.
Second, after successfully saving data, the server must return an HTML page that contains the submitted JSON. Currently, it's returning a raw JSON response with a Content-Type of 'application/json'. Please change this to 'text/html' and ensure the response body is a valid HTML document that includes the JSON data.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| /* Write your code here */ | ||
| // Return instance of http.Server class | ||
| return http.createServer((req, res) => { | ||
| if (req.method === 'POST' && req.url === '/add-expense') { |
There was a problem hiding this comment.
This if block only handles the POST request for submitting data. The task also requires the server to "show an HTML form". You'll need to add logic, for example, using an else if, to handle a GET request that serves the form page to the user.
src/createServer.js
Outdated
| ); | ||
|
|
||
| res.writeHead(200, { | ||
| 'Content-Type': 'application/json', |
There was a problem hiding this comment.
The requirement is to "return an HTML page with well formatted JSON". Setting the Content-Type to 'application/json' is incorrect for an HTML page. This should be 'text/html', and the response body should be a valid HTML document containing the JSON.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! You have successfully addressed all the feedback from the previous review, resulting in a solution that now meets all project requirements. The server correctly serves the initial HTML form, processes the submitted data via a POST request, and returns a well-formatted confirmation page. I am happy to confirm your solution is complete.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.