Wrote a server that reads request url and query and returns a JSON#367
Open
oleksandr-kovalchuk wants to merge 2 commits intomate-academy:masterfrom
Open
Wrote a server that reads request url and query and returns a JSON#367oleksandr-kovalchuk wants to merge 2 commits intomate-academy:masterfrom
oleksandr-kovalchuk wants to merge 2 commits intomate-academy:masterfrom
Conversation
mateacademy-ai-mentor
approved these changes
Feb 25, 2025
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Great job on implementing the server functionality! 🎉 The code meets the task requirements by correctly parsing the URL and query parameters. While there are a couple of areas for improvement, such as handling different response status codes and adding error handling for URL parsing, these do not impact the core functionality. Keep up the good work and consider these enhancements for future projects to make your code even more robust! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Params server