Open
Conversation
mateacademy-ai-mentor
approved these changes
Mar 12, 2025
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Great job on implementing the basic HTTP server in createServer.js! 🎉 The code meets the task requirements and correctly handles the request URL and query. Just a small note: the condition if (!parts) will always be false since parts is an array. You might want to check if the array is empty using if (parts.length === 0) instead. Keep up the good work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/createServer.js
Outdated
|
|
||
| console.log(reqUrl); | ||
|
|
||
| if (!parts) { |
There was a problem hiding this comment.
The condition if (!parts) will always evaluate to false because parts is an array and will always be truthy. Consider checking if the array is empty instead, like if (parts.length === 0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.