Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thank you for your work! There is a critical issue: the pathname normalization is not effective because the result of the replace operation is not reassigned back to givenUrl.pathname. As a result, the server does not actually normalize double slashes in the path as required by the task. Please fix this by assigning the result of the normalization back to the variable (e.g., givenUrl.pathname = givenUrl.pathname.replaceAll('//', '/')). Once this is corrected, your code will fully meet the requirements. Keep going—you're almost there! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/createServer.js
Outdated
| console.log(givenUrl); | ||
|
|
||
| if (givenUrl.pathname.includes('//')) { | ||
| givenUrl.pathname.replaceAll('//', '/'); |
There was a problem hiding this comment.
Issue: The result of givenUrl.pathname.replaceAll('//', '/') is not assigned back to givenUrl.pathname. This means the normalization does not actually update the pathname. You need to assign the result back to givenUrl.pathname for the normalization to take effect.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your implementation meets all the core requirements and constraints of the task. The normalization logic is correctly applied, all critical issues have been addressed, and there are no unnecessary or missing files. Keep up the good work and continue following best practices!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
3 participants
No description provided.