Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thank you for your work! Your implementation is almost correct and meets most requirements, but there is a critical issue with how you split the pathname into segments. Using replaceAll('/', ' ') and then splitting by spaces does not properly handle multiple consecutive slashes, which can result in empty segments in the parts array. This does not comply with the requirement to ignore empty segments caused by leading, trailing, or consecutive slashes. Please update your logic to use .split('/') and filter out empty strings (e.g., pathname.split('/').filter(Boolean)). Once you fix this, your solution will fully meet the requirements. Keep going—you’re very close! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/createServer.js
Outdated
| .replaceAll('/', ' ') | ||
| .split(' ') |
There was a problem hiding this comment.
This approach to splitting the pathname into parts (replaceAll('/', ' ') followed by .split(' ')) may not handle multiple consecutive slashes correctly. If the task requires robust parsing of path segments, consider splitting directly by '/' and filtering out empty strings.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your implementation now fully meets all the core requirements: pathname segments are correctly parsed and filtered, query parameters are handled as specified, and the JSON output matches the task description. There are no outstanding issues, so your code is ready to be accepted. Keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.