Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thank you for your hard work! 😊 Your implementation is almost complete and meets most of the requirements. However, there is a critical issue: the code currently splits the pathname into individual characters instead of path segments. This means that, for example, /foo/bar//baz would be split into characters like ['/', 'f', 'o', 'o', ...] instead of the required segments ['foo', 'bar', 'baz']. To fix this, you should remove the spread operator and apply slice, replace, and split directly to url.pathname, making sure to split by '/' and filter out any empty segments. Once you address this, your solution will fully meet the task requirements. Keep going—you’re very close! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/createServer.js
Outdated
| ...url.pathname | ||
| .slice(1) | ||
| .replace(/\/{2,}/g, '/') | ||
| .split('/'), |
There was a problem hiding this comment.
Issue: The code spreads url.pathname into an array of characters before slicing, replacing, and splitting. This results in an array of characters, not path segments. To get path segments, you should first normalize the pathname, then split it by '/'.
Hint: Remove the spread operator and apply slice, replace, and split directly to url.pathname.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your implementation meets all the core requirements and constraints of the task. The server correctly parses the pathname and query parameters, handles doubled slashes, and returns the expected JSON structure. All previous issues have been resolved, and your code is ready for acceptance. Keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.