solution for Params echo server#414
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your code meets all the core requirements and handles edge cases as expected. The only minor issue is that the 'path' property in testRequest.js is commented out, but this doesn't affect the main server functionality. Keep up the good work, and consider uncommenting or setting the 'path' in your test utility for more effective testing in the future!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| const options = { | ||
| hostname: 'localhost', | ||
| port: 5701, | ||
| // path: '//123?sex=male&age=25&age=40', | ||
| // path: '//123/one/two/three?sex=male&age=25&age=40&x=&y=&=0', | ||
| // path: '/test', | ||
| // path: '?param1=¶m2=', | ||
| }; |
There was a problem hiding this comment.
Issue: The 'options' object does not have a 'path' property set, as all possible 'path' lines are commented out. This will result in the request being sent to the root path ('/'), which may not be what you intend for testing various cases. Please uncomment or set the 'path' property to test specific routes as needed.
2 participants
No description provided.