Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job setting up the server and correctly handling the query parameters! Your solution is very close to complete.
However, this requires a change because the logic for splitting the pathname doesn't account for doubled slashes, which is a core requirement. For a path like //hello/world, your code currently produces ["", "hello", "world"] instead of the expected ["hello", "world"].
You can fix this by filtering out the empty strings that result from splitting the pathname. Chaining a .filter(part => part) after your .split('/') call is an effective way to achieve this. Once that's updated, your code should pass all the requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/createServer.js
Outdated
| res.setHeader('Content-Type', 'application/json'); | ||
|
|
||
| const requestURL = new URL(req.url, `http://${req.headers.host}`); | ||
| const parts = requestURL.pathname.split('/').slice(1); |
There was a problem hiding this comment.
This logic for splitting the pathname doesn't account for the requirement to ignore doubled slashes. For a path like //hello/world, this will produce ['', 'hello', 'world'] instead of the expected ['hello', 'world']. Consider filtering out the empty strings that result from splitting the pathname.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this update! I am approving your solution as you've successfully addressed the feedback from the previous review. The logic for parsing the URL pathname now correctly handles doubled slashes by filtering out the empty parts. Your code is clean, concise, and meets all the task requirements. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.