node_static-files-server_TetSh#339
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on the server implementation, especially the security check to prevent path traversal! However, this requires a change because a key requirement is not met.
Your server currently returns a 404 error for requests to /file/ instead of serving public/index.html. This is because your logic for extracting the file path from the URL results in '/' for the /file/ endpoint. Since this is not an empty string, your fallback to index.html is not triggered, and the server incorrectly tries to read a directory.
Please adjust your logic to ensure that requests to both /file and /file/ correctly serve the index.html file as specified in the requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/createServer.js
Outdated
| return; | ||
| } | ||
|
|
||
| const filePath = pathname.replace('/file', '') || 'index.html'; |
There was a problem hiding this comment.
This logic doesn't correctly handle the case where the pathname is exactly /file/. According to the requirements, a request to /file/ should serve index.html. With the current implementation, filePath becomes '/', which causes fs.readFile to fail on a directory path, leading to a 404 error. Consider adjusting the logic to correctly map both /file and /file/ to index.html.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! You've successfully resolved the issue from the previous review, and the server now correctly handles requests for both /file and /file/ by serving the index.html file. Your implementation is clean, meets all project requirements, and includes a robust security check to prevent path traversal. I am approving your solution, great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.