Skip to content

solution_sorted_variables#3402

Open
DrSimi0 wants to merge 3 commits intomate-academy:masterfrom
DrSimi0:develop
Open

solution_sorted_variables#3402
DrSimi0 wants to merge 3 commits intomate-academy:masterfrom
DrSimi0:develop

Conversation

@DrSimi0
Copy link
Copy Markdown

@DrSimi0 DrSimi0 commented Mar 27, 2026

Solucion del sorted_variables con un diccionario llamado sorted_variables ( este diccionario tiene como valores "mutable" : (tiene como valor una lista vacia ) y el otro es "inmutable " ( igual con valor de lista vacia )). Use una lista para agregar todos las variables y poder usar un for para automatizarlo, asi podre hacer un if con isinstance ( una funcion integrada de python donde como primer termino se pone "variable" que es donde se guarda la variable en cada vuelta del loop. Tengo dos condiciones donde una tiene int, float, bool, str, tuple. El otro tiene list, dict, set. Y asi los divido por mutable e inmutable

Cuando una condicion se cumple lo apendo segun su formato

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on this task! I am approving your solution because it correctly implements all the requirements. Your code successfully identifies and sorts the variables into 'mutable' and 'immutable' lists as specified.

I did notice a minor linting warning (VNE002) about the variable name variable in app/main.py. While this doesn't affect the functionality, using more descriptive names is a great habit for improving code readability. Keep up the excellent work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link
Copy Markdown
Author

@DrSimi0 DrSimi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

olvide poner ctrl s cuando corregi

@DrSimi0
Copy link
Copy Markdown
Author

DrSimi0 commented Mar 27, 2026

ya lo hice

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! I am approving your solution as it perfectly meets all the requirements. You've correctly created the sorted_variables dictionary and successfully sorted all the variables into the appropriate mutable and immutable lists. The logic is clear and effective. Keep up the great coding!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants