Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This requires a few changes before it can be approved. You've done a great job setting up the sorted_variables dictionary with the correct "mutable" and "immutable" keys. However, the main issue is that you're using variables in your lists (like list_of_students and academy_name) that are not defined in the file. This causes the program to crash with a NameError.
The goal of this task is to categorize the variables provided at the top of the app/main.py file (lucky_number, pi, my_favourite_films, etc.) into the correct list based on whether their type is mutable or immutable. Please revisit the task and sort the existing variables into your dictionary.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
app/main.py
Outdated
| sorted_variables = { | ||
| "mutable": [list_of_students, student_info, collection_of_coins], | ||
| "immutable": [academy_name, number_of_students, average_mark, is_active, main_course] | ||
| } |
There was a problem hiding this comment.
It looks like you're using variables that aren't defined in this file, such as list_of_students and academy_name. The task is to categorize the variables defined at the beginning of this file (lucky_number, pi, my_favourite_films, etc.) into the appropriate lists based on whether they are mutable or immutable.
2 participants
No description provided.