Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this task! All the functional requirements are implemented correctly and the components work as expected. I am requesting one small change to align with the project's coding standards.
In src/components/Person/Person.jsx, the nested ternary operator for partnerStatus is not formatted correctly. According to the project's style guide [CHECKLIST ITEM #2], each operand of a ternary operator must be on a new line to improve readability.
Please apply this formatting change, and your solution will be ready for approval. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Person/Person.jsx
Outdated
| const { name, age, sex, isMarried, partnerName } = person; | ||
|
|
||
| const partnerStatus = isMarried | ||
| ? `${partnerName} is my ${sex === 'm' ? 'wife' : 'husband'}` |
There was a problem hiding this comment.
This nested ternary operator should also be formatted according to the style guide. Please move each operand to a new line to improve readability, as required by checklist item #2.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! I am approving your solution as you've successfully addressed all the previous feedback. The code is now clean, readable, and fully compliant with all task requirements. The components are well-implemented, and the formatting, particularly for the nested ternary operator, is now correct. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
[DEMO LINK](https://nnovik.github.io/react_person/