Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on implementing the functional requirements! The component behaves correctly and handles all the specified logic. However, I'm requesting a couple of changes to align your code with the project's style guide, as specified in the checklist.
In src/components/Person/Person.jsx, there are two items to address:
- Please destructure the properties from the
personobject (likename,age,sex) at the beginning of the component. This avoids repeatingperson.throughout your JSX. [CHECKLIST ITEM #1] - The ternary operator used to assign the
partnerLabelshould be formatted across multiple lines to improve readability. [CHECKLIST ITEM #2]
Once these styling adjustments are made, your solution will be ready for approval. Keep up the excellent effort!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -1 +1,19 @@ | |||
| // export const Person = ({ person }) => (); | |||
| export const Person = ({ person }) => { | |||
There was a problem hiding this comment.
This violates checklist item #1: 'Use destructuring for getting access to values of props object'. While you've destructured the person prop, you should also destructure the properties from the person object itself (e.g., name, age, sex). This will make the JSX code in the return statement cleaner by removing the repeated person. prefix.
| @@ -1 +1,19 @@ | |||
| // export const Person = ({ person }) => (); | |||
| export const Person = ({ person }) => { | |||
| const partnerLabel = person.sex === 'm' ? 'wife' : 'husband'; | |||
There was a problem hiding this comment.
This violates checklist item #2: 'Format ternary operator operands correctly - move each operand to the separate line'. For better readability, this ternary operator should be split into multiple lines.
No description provided.