Skip to content

Develop#3653

Open
vakt159 wants to merge 2 commits intomate-academy:masterfrom
vakt159:develop
Open

Develop#3653
vakt159 wants to merge 2 commits intomate-academy:masterfrom
vakt159:develop

Conversation

@vakt159
Copy link
Copy Markdown

@vakt159 vakt159 commented Mar 31, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on implementing the functional requirements! The component behaves correctly and handles all the specified logic. However, I'm requesting a couple of changes to align your code with the project's style guide, as specified in the checklist.

In src/components/Person/Person.jsx, there are two items to address:

  1. Please destructure the properties from the person object (like name, age, sex) at the beginning of the component. This avoids repeating person. throughout your JSX. [CHECKLIST ITEM #1]
  2. The ternary operator used to assign the partnerLabel should be formatted across multiple lines to improve readability. [CHECKLIST ITEM #2]

Once these styling adjustments are made, your solution will be ready for approval. Keep up the excellent effort!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@@ -1 +1,19 @@
// export const Person = ({ person }) => ();
export const Person = ({ person }) => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #1: 'Use destructuring for getting access to values of props object'. While you've destructured the person prop, you should also destructure the properties from the person object itself (e.g., name, age, sex). This will make the JSX code in the return statement cleaner by removing the repeated person. prefix.

@@ -1 +1,19 @@
// export const Person = ({ person }) => ();
export const Person = ({ person }) => {
const partnerLabel = person.sex === 'm' ? 'wife' : 'husband';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Format ternary operator operands correctly - move each operand to the separate line'. For better readability, this ternary operator should be split into multiple lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants