Skip to content

Fix some memory problem that report by valgrind #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkareh merged 4 commits into from
May 5, 2026
+11 −1
Merged

Fix some memory problem that report by valgrind #1886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9102ab4
emblem-sidebar: fix memory leak of popup menu widget
gaobo-kylinsec Apr 23, 2026
4fa5180
icon-info: fix cache key mismatch for loadable icons
gaobo-kylinsec Apr 23, 2026
bc5cf51
notes-viewer: fix memory leak of text buffer
gaobo-kylinsec Apr 23, 2026
da3f865
window-menus: fix memory leak of menu and action objects
gaobo-kylinsec Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcaja-private/caja-icon-info.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ caja_icon_info_lookup (GIcon *icon,

lookup_key.icon = icon;
lookup_key.scale = scale;
lookup_key.size = size * scale;
lookup_key.size = size;
Comment thread
gaobo-kylinsec marked this conversation as resolved.

icon_info = g_hash_table_lookup (loadable_icon_cache, &lookup_key);
if (icon_info)
Expand Down
4 changes: 4 additions & 0 deletions src/caja-emblem-sidebar.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,10 @@ create_popup_menu (CajaEmblemSidebar *emblem_sidebar)

popup = gtk_menu_new ();

gtk_menu_attach_to_widget (GTK_MENU (popup),
GTK_WIDGET (emblem_sidebar),
NULL);

gtk_menu_set_reserve_toggle_size (GTK_MENU (popup), FALSE);

/* add the "rename" menu item */
Expand Down
2 changes: 2 additions & 0 deletions src/caja-notes-viewer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ caja_notes_viewer_init (CajaNotesViewer *sidebar)
/* create the text container */
details->text_buffer = gtk_text_buffer_new (NULL);
details->note_text_field = gtk_text_view_new_with_buffer (details->text_buffer);
// gtk_text_view_new_with_buffer will add reference to text buffer
g_object_unref (details->text_buffer);

gtk_text_view_set_editable (GTK_TEXT_VIEW (details->note_text_field), TRUE);
gtk_text_view_set_wrap_mode (GTK_TEXT_VIEW (details->note_text_field),
Expand Down
4 changes: 4 additions & 0 deletions src/caja-window-menus.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,11 @@ add_extension_menu_items (CajaWindow *window,

caja_menu_item_list_free (children);
g_free (subdir);

g_object_unref (menu);
}

g_object_unref (action);
}
}

Expand Down
Loading