mate-screenshot: Restore aysnchronous saving #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore asynchronous screenshot saving to improve reactivity, but use proper asynchronous APIs instead of the previous dangerous fork()-based solution, that mostly worked out of luck and stopped working with newer gdk-pixbuf versions.
While at it, also create the temporary directory asynchronously, rather than this part being the only synchronous operation.
|
I am getting the following build error with this patch: As much as I've been able to find, |
Older versions don't have g_file_new_tmp_dir_async(), so emulate it there for compatibility.
Member
Author
|
@L-U-T-i ah, bummer. I just pushed a poor man's compatibility wrapper that seem to work fine. Tell me if that's still not enough. @mate-desktop/core-team if the async directory stuff is getting too much out of hand, I can also drop it. Although nice, it used to be synchronous anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #368 to restore asynchronous screenshot saving, but doing it more reasonably this time (before #368 it was using a
exec()-lessfork(), which is unsafe when using GTK libraries, leading to bugs).