Skip to content

Conversation

@joshfg
Copy link

@joshfg joshfg commented Feb 19, 2014

No description provided.

Hyphen is also a valid character in hostnames
Filter Hive output by removing any logging lines (detected as a line
beginning with '[').

Currently, when running Hive with Hadoop 2, Hive will output log
messages to the console.
E.g. [deprecation] - mapred.reduce.tasks is deprecated. Instead, use
mapreduce.job.reduces

This commit filters out these log messages before processing the Hive
output.
@FelixGV
Copy link
Contributor

FelixGV commented Feb 24, 2014

Hi,

Sorry for the delay!

I'm fine with the hostname regex change, but I don't really like the change to Hive's logging. It seems like this could hide legitimate [ERROR] logs... Plus, it makes it even more apparent that the duplicated code around hive commands is ugly. I'd like to refactor all that more properly..

Anyway!

I'll probably cherry pick the hostname regex change and I don't know yet what I'll do with the hive stuff...

-F

@joshfg
Copy link
Author

joshfg commented Feb 24, 2014

Hi Felix,

OK that's cool I thought the log filtering was a bit hacky but checked it
in anyway just in case you wanted it in there

Thanks,
Josh

On Mon, Feb 24, 2014 at 4:16 AM, FelixGV notifications@github.com wrote:

Hi,

Sorry for the delay!

I'm fine with the hostname regex change, but I don't really like the
change to Hive's logging. It seems like this could hide legitimate [ERROR]
logs... Plus, it makes it even more apparent that the duplicated code
around hive commands is ugly. I'd like to refactor all that more properly..

Anyway!

I'll probably cherry pick the hostname regex change and I don't know yet
what I'll do with the hive stuff...

-F

Reply to this email directly or view it on GitHubhttps://github.com//pull/2#issuecomment-35856648
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants