Skip to content

[TimePicker] Make the dial selector discrete #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[TimePicker] Make the dial selector discrete #4910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/java/com/google/android/material/timepicker/ClockFaceView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ class ClockFaceView extends RadialViewGroup implements OnRotateListener {

private String[] values;

private float currentHandRotation;
private float currentHandDegrees;
private float currentHandLevel;

private final ColorStateList textColor;

Expand Down Expand Up @@ -366,11 +367,14 @@ private RadialGradient getGradientForTextView(RectF selectorBox, TextView tv) {
}

@Override
public void onRotate(float rotation, boolean animating) {
if (abs(currentHandRotation - rotation) > EPSILON) {
currentHandRotation = rotation;
findIntersectingTextView();
public void onRotate(float degrees, int level, boolean animating) {
if (currentHandDegrees == degrees && currentHandLevel == level) {
return;
}

currentHandDegrees = degrees;
currentHandLevel = level;
findIntersectingTextView();
}

@Override
Expand Down
Loading