Skip to content

DevOps: CI and Pre-commit#108

Merged
giovannipizzi merged 1 commit intomaterialscloud-org:mainfrom
t-reents:dev/update_gh_ci
Mar 31, 2025
Merged

DevOps: CI and Pre-commit#108
giovannipizzi merged 1 commit intomaterialscloud-org:mainfrom
t-reents:dev/update_gh_ci

Conversation

@t-reents
Copy link
Collaborator

@t-reents t-reents commented Dec 9, 2024

  • Update CI to use recent versions of actions and extend the Python versions that are used for testing
  • Update Pre-commit to use newer versions of the hooks. Moreover, additional hooks have been added
  • Included and fixed prospectorfixes Activate prospector and fix problems #88

@t-reents t-reents marked this pull request as draft December 9, 2024 11:16
@t-reents
Copy link
Collaborator Author

t-reents commented Dec 9, 2024

Tests are still working but pre-commit is of course failing due to the new changes that would be introduced by the new hooks.

@t-reents t-reents marked this pull request as ready for review January 14, 2025 16:17
@t-reents t-reents force-pushed the dev/update_gh_ci branch 4 times, most recently from eac820e to 22eaa3b Compare February 6, 2025 09:48
A few changes have been made to update the github CI and the pre-commit hooks.

* Use more python versions in the CI to ensure those are supported

* The pre-commit hooks are updated to more recent versions, and additional (standard) hooks are introduced, e.g. EOF or double-quote fixer

* pre-commit: `ruff` replaces `black`

* pre-commit: `prospector` is enabled and all warnings/errors (e.g. pylint) have been adjusted accordingly
@t-reents t-reents closed this Mar 31, 2025
@t-reents t-reents reopened this Mar 31, 2025
@giovannipizzi giovannipizzi merged commit 9ca3dd9 into materialscloud-org:main Mar 31, 2025
12 checks passed
@giovannipizzi
Copy link
Collaborator

Since new tests have been added, I'm bypassing rules and merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activate prospector and fix problems

2 participants