Skip to content

Conversation

@esoteric-ephemera
Copy link
Collaborator

@esoteric-ephemera esoteric-ephemera commented Oct 17, 2025

Changes related to serialization behavior changes that started in emmet-core==0.86.0rc0, ensuring compatibility with emmet-core==0.86.0rc1 here.

Summary:

  • Ensure structures are returned as objects in materials endpoint. This was probably previously an issue with monty_decode=False too
  • Allow dict-like key access of MPDataDoc objects, + add a .get method. Reduces use_document_model boilerplate and permits pandas-like parity between dot-notation and key-item access

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 74.13793% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.85%. Comparing base (254c7d0) to head (089c157).

Files with missing lines Patch % Lines
mp_api/client/mprester.py 76.19% 5 Missing ⚠️
mp_api/client/core/client.py 76.92% 3 Missing ⚠️
mp_api/client/routes/materials/materials.py 57.14% 3 Missing ⚠️
...pi/client/routes/materials/electronic_structure.py 86.66% 2 Missing ⚠️
mp_api/client/routes/molecules/molecules.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   66.72%   66.85%   +0.13%     
==========================================
  Files          50       50              
  Lines        2777     2767      -10     
==========================================
- Hits         1853     1850       -3     
+ Misses        924      917       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@esoteric-ephemera esoteric-ephemera changed the title [WIP] Compatibility with emmet-core 0.86.0rc1 Compatibility with emmet-core 0.86.0rc1 Oct 24, 2025
@esoteric-ephemera
Copy link
Collaborator Author

@tschaume ready for review whenever you get a chance!

Copy link
Member

@tschaume tschaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner! Thank you. Just a couple of minor questions.

@tschaume tschaume merged commit 69e3715 into main Oct 24, 2025
4 checks passed
@tschaume tschaume deleted the compat-86 branch October 24, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants