-
Notifications
You must be signed in to change notification settings - Fork 51
Compatibility with emmet-core 0.86.0rc1 #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
+ Coverage 66.72% 66.85% +0.13%
==========================================
Files 50 50
Lines 2777 2767 -10
==========================================
- Hits 1853 1850 -3
+ Misses 924 917 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… and clean up use_document_model boilerplate
|
@tschaume ready for review whenever you get a chance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much cleaner! Thank you. Just a couple of minor questions.
Changes related to serialization behavior changes that started in
emmet-core==0.86.0rc0, ensuring compatibility with emmet-core==0.86.0rc1 here.Summary:
materialsendpoint. This was probably previously an issue withmonty_decode=FalsetooMPDataDocobjects, + add a.getmethod. Reducesuse_document_modelboilerplate and permitspandas-like parity between dot-notation and key-item access