-
Notifications
You must be signed in to change notification settings - Fork 80
Migrate LOBSTER schemas from atomate2 #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1296 +/- ##
===========================================
- Coverage 86.02% 85.37% -0.65%
===========================================
Files 229 230 +1
Lines 17908 18254 +346
===========================================
+ Hits 15405 15585 +180
- Misses 2503 2669 +166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2d35995 to
de5b5c9
Compare
a829151 to
c3f0c80
Compare
c3f0c80 to
dc95437
Compare
dc95437 to
063116c
Compare
|
Hi @esoteric-ephemera , I will make some changes if needed on this branch, one thing I could see is we need to read CONTCAR as we do in atomate2. currently POSCAR is being read here. |
901e36c to
173f2b9
Compare
Had previously started this without opening a PR - resuming the migration here to allow for edits from @naik-aakash and @JaGeo as needed for a related crystal toolkit PR
Migrates + updates the schemas used in atomate2 for LOBSTER calcs. Removes ijson dependence in favor of JSON lines files + orjson. Should probably be parquet in the long run to make it more efficient