Skip to content

feat: Allow for negative years #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucalbus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Allow for negative years #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/logic/cubit/edit_book_cubit.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class EditBookCubit extends Cubit<Book> {
void setPublicationYear(String publicationYear) {
final book = state.copyWith();
book.publicationYear =
publicationYear.isEmpty ? null : int.parse(publicationYear);
publicationYear.isEmpty ? null : int.tryParse(publicationYear);

emit(book);
}
Expand Down
7 changes: 5 additions & 2 deletions lib/ui/add_book_screen/add_book_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,9 +556,12 @@ class _AddBookScreenState extends State<AddBookScreen> {
icon: FontAwesomeIcons.solidCalendar,
keyboardType: TextInputType.number,
inputFormatters: <TextInputFormatter>[
FilteringTextInputFormatter.digitsOnly
// allow optional leading '-' for BCE years
FilteringTextInputFormatter.allow(
RegExp(r'^-?\d{0,4}')),
],
maxLength: 4,
// allow space for a leading '-' (e.g. -500)
maxLength: 5,
padding: const EdgeInsets.fromLTRB(5, 0, 10, 0),
),
),
Expand Down