[feat] support for multiple subjects #535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-by: ptorrx <ptorrx@gmail.com>
CohenCyril
reviewed
Apr 30, 2025
HB/structures.v
Outdated
Comment on lines
729
to
732
|
|
||
| % hack | ||
| std.forall {std.iota 20} (x\begin-section "x",end-section), | ||
|
|
There was a problem hiding this comment.
We have to announce the sections we open/close. And statically I don't know.
Unfortunately coq lacks the notion of irrelevant synterp actions, even if our sections don't interfere with parsing they could.
|
@CohenCyril commit 64966fd is not wrapper specific and seems to fix a limitation of HB.saturate, that was always applying the key to too many arguments. |
"Foo.Build T extra" is like "Foo.Axioms T _ extra" but before typing "extra" it ensures/infers that T has the needed structue, eg "Foo.Axioms T T__hasThis extra" In turn this can make the typing of "extra" simpler since the _ could occur in the expected type of "extra".
When we build the wrapped we infer the subject. If the subject has deps, it is inferred as the sort projection of its canon instance satisfying all deps. For now I do a whd, but one should probably be less aggressive. This needs discussion since subject are GIVEN not inferred, usually.
apparently something is off is deps are mixed between the subject and its lifted variants
factories on the wrapper subjects do not trigger both the instances on the wrapped subject. The beahviour when not using the factory is the expected one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.